Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): make init use values from capacitor.config.json as defaults #2620

Merged
merged 2 commits into from
Mar 23, 2020
Merged

feat(cli): make init use values from capacitor.config.json as defaults #2620

merged 2 commits into from
Mar 23, 2020

Conversation

jcesarmobile
Copy link
Member

If npx cap init is called but a capacitor.config.json already exists, use the values there as defaults.

This is specially important for react apps as some guides tell users to run npx cap init after ionic integration, and that sets the webDir value to www instead of build.

@jcesarmobile jcesarmobile merged commit 9157e1f into ionic-team:master Mar 23, 2020
@jcesarmobile jcesarmobile deleted the defauls-cli branch March 23, 2020 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jcesarmobile